Make yum repo GPG key an attribute #326
Conversation
|
Thanks @iancward, this looks good! We'll include it in the next minor release. |
| @@ -62,10 +62,14 @@ | |||
| } | |||
| architecture_map.default = 'x86_64' | |||
|
|
|||
| # Older versions of yum embed M2Crypto with SSL that doesn't support TLS1.2 | |||
| prefix = node['platform_version'].to_i < 6 ? 'http' : 'https' | |||
There was a problem hiding this comment.
After giving it some thought, I think this deserves a more accurate condition since it will run on all platforms. Could you change this to:
yum_protocol = 'https'
if node['platform_family'] == 'rhel' && node['platform_version'].to_i < 6
# Older versions of yum embed M2Crypto with SSL that doesn't support TLS1.2
yum_protocol = 'http'
end(I've also renamed prefix yum_protocol since that name makes more sense here IMO)
There was a problem hiding this comment.
I merely migrated the code from the repository recipe, but I just noticed that it's inside of a case node['platform_family'] block.
This is fixed in 6eb91d7. I did it a bit differently to try to be more DRY.
|
@iancward Just added a comment actually, let me know what you think, thanks! |
|
Thanks @iancward, looks better now, I think this is ready for the next minor release |
|
@iancward Thanks for your efforts on this PR. We're currently working through a QA/testing cycle on the next release, which we expect to include this PR. |
This fixes GH-311.